You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
The goal of this issue is to make sure that the _newPeers and _triedPeers (address book) does not grow to unlimited size. This should be done according to the LIP.
We still need to consider the size of each PeerInfo within the lists.
This issue also involves making sure that peers are moved between the two lists according to the LIP.
Description
This is related to https://github.com/LiskHQ/lisk-elements/issues/1072 - The _newPeers and _triedPeers maps (which store P2PDiscoveredPeerInfo) need to have a size limit to prevent DoS. The LIP has a mechanism which limits the size of the _newPeers and _triedPeers maps so it should be implemented.
Actual behavior
_newPeers and _triedPeers are not currently managed according to the LIP.
The text was updated successfully, but these errors were encountered:
jondubois
changed the title
Enforce a size limit on the _newPeers and _triedPeers lists
Fix _newPeers and _triedPeers maps to match the LIP
May 21, 2019
jondubois
changed the title
Fix _newPeers and _triedPeers maps to match the LIP
Fix _newPeers and _triedPeers to match the LIP
May 21, 2019
This issue is there to address any remaining details which may be left over in order to fully comply with the LIP regarding the management of the the address book (_newPeers and _triedPeers).
Expected behavior
Scope
The goal of this issue is to make sure that the _newPeers and _triedPeers (address book) does not grow to unlimited size. This should be done according to the LIP.
Description
This is related to https://github.com/LiskHQ/lisk-elements/issues/1072 - The
_newPeers
and_triedPeers
maps (which storeP2PDiscoveredPeerInfo
) need to have a size limit to prevent DoS. The LIP has a mechanism which limits the size of the_newPeers
and_triedPeers
maps so it should be implemented.Actual behavior
_newPeers
and_triedPeers
are not currently managed according to the LIP.The text was updated successfully, but these errors were encountered: