Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

API : getTransactions with both senderId and recipientId parameters not working at all #379

Closed
sheerlox opened this issue Jan 7, 2017 · 4 comments
Closed

API : getTransactions with both senderId and recipientId parameters not working at all #379

sheerlox opened this issue Jan 7, 2017 · 4 comments
Assignees
@4miners
Labels
type: improvement

Comments

@sheerlox
Copy link

sheerlox commented Jan 7, 2017

In example :
https://login.lisk.io/api/transactions?senderId=9120485202270553493L&recipientId=7023069056644097238L

How can I do I absolutely need this to build the transparency reports tool 馃槙 ?
@sheerlox
Copy link
Author

sheerlox commented Jan 7, 2017

Just see that :
All parameters join by "OR".

Sorry

@sheerlox sheerlox closed this as completed Jan 7, 2017
@4miners
Copy link
Contributor

4miners commented Jan 7, 2017

Yep, I know, but such a search is useful and we need to allow it - so reopen. That endpoint should be redesigned at all.

@4miners 4miners reopened this Jan 7, 2017
@4miners 4miners self-assigned this Jan 7, 2017
@sheerlox
Copy link
Author

sheerlox commented Jan 7, 2017

Done that, not optimized but will do the job for now https://github.com/SherlockStd/lisk-transparency-reports/blob/34eed483b99a4f3f6e182ab7a66a211c9cad9b8e/helpers/blockchain.js#L43-L69

@4miners 4miners mentioned this issue Jan 7, 2017
Closed
@simonmorgenthaler
Copy link

Related to #265

@4miners 4miners mentioned this issue Jan 24, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@4miners 4miners

Labels
type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karmacoma @simonmorgenthaler @sheerlox @4miners