Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add new integration tests for TokenAPI #7233

Closed
Tracked by #7246
has5aan opened this issue Jun 21, 2022 · 1 comment
Closed
Tracked by #7246

Add new integration tests for TokenAPI #7233

has5aan opened this issue Jun 21, 2022 · 1 comment
Assignees
Milestone

Comments

@has5aan
Copy link
Contributor

has5aan commented Jun 21, 2022

Description

Following modules and their containing commands are dependent on TokenAPI and make good candidates for integration tests.

Modules dependent on TokenAPI

  • DPosModule
  • RewardModule
  • FeeModule

DPoSModule

  • DPoSModule.finalizeGenesisState consumes TokenAPI.getLockedAmount

Commands

  • ReportDelegateMisbehaviorCommand.execute consumes TokenAPI.getAvailableBalance
  • UnlockCommand.execute cosumes TokenAPI.unlock
  • VoteCommand.execute consumes TokenAPI.lock

FeeModule

  • FeeModule.beforeCommandExecute consumes TokenAPI.transfer and TokenAPI.burn

RewardModule

  • RewardModule.afterTransactionsExecute consumes TokenAPI.mint

Which version(s) does this affect? (Environment, OS, etc...)

Lisk SDK development branch.

@has5aan has5aan changed the title Add new integration test for FeeModule and TransactionAPI Add new integration tests for TokenAPI Jun 27, 2022
@Madhulearn Madhulearn added this to the Sprint 84 milestone Dec 5, 2022
@Madhulearn Madhulearn modified the milestones: Sprint 84, Sprint 85 Dec 19, 2022
@Madhulearn Madhulearn modified the milestones: Sprint 85, Sprint 86 Jan 3, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 86, Sprint 87 Jan 17, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 87, Sprint 88 Jan 30, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 88, Sprint 89 Feb 13, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 89, Sprint 90 Feb 28, 2023
@shuse2 shuse2 removed this from the Sprint 90 milestone Mar 2, 2023
@Madhulearn Madhulearn added this to the Sprint 94 milestone Apr 24, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 94, Sprint 95 May 9, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 95, Sprint 96 May 22, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 96, Sprint 97 Jun 5, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 97, Sprint 98 Jun 20, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 98, Sprint 99 Jul 4, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 99, Sprint 100 Jul 18, 2023
@Madhulearn Madhulearn added this to the Sprint 109 milestone Nov 21, 2023
@has5aan
Copy link
Contributor Author

has5aan commented Nov 28, 2023

The test improvement suggested by the issue for TokenMethod (previously TokenAPI) in components consuming it have been tested and reviewed in the current unit test improvement activity. The relevant action on the suggestion would require implementation of integration tests for the each module dependent on the TokenMethod which doesn't serve practically effective improvements.

@has5aan has5aan closed this as completed Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants