Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Improve inbox update calculation #8033

Closed
Tracked by #7210
ishantiw opened this issue Jan 17, 2023 · 0 comments · Fixed by #8112
Closed
Tracked by #7210

Improve inbox update calculation #8033

ishantiw opened this issue Jan 17, 2023 · 0 comments · Fixed by #8112

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jan 17, 2023

Description

As of now we iterate over all the CCMs between lastCertificate and current certificate height, group them by size that can fit into a CCU. based on the number of groups we form multiple inboxUpdates and send them via multiple CCUs.

We can optimise this by,

  • When certificate is not found on the new block event then we simply continue with execution taking the lastCertificate
  • We can send rest of CCUs with remaining CCMs (Partial updates) with every new block by taking CCMs > lastCCMSent.nonce
  • Only send one CCU (full or partial) that is created for every new block

Acceptance Criteria

  • Should pass all the unit tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants