Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify LSK getTransactions API util filters #1988

Closed
slaweet opened this issue May 8, 2019 · 0 comments
Closed

Simplify LSK getTransactions API util filters #1988

slaweet opened this issue May 8, 2019 · 0 comments
Assignees
@slaweet
Labels
type: refactoring
Milestone
Implement BTC log...

Comments

@slaweet
Copy link
Contributor

slaweet commented May 8, 2019 •
edited
Loading

Actual situation

There is a lot of conditions in LSK getTransactions API util
https://github.com/LiskHQ/lisk-hub/blob/0fd989b6795d7874093dca995a9412b4371d7cc1/src/utils/api/lsk/transactions.js#L30-L56

Expected situation

getTransactions should be a lot simpler, so it doesn't have to have eslint checks disabled
https://github.com/LiskHQ/lisk-hub/blob/0fd989b6795d7874093dca995a9412b4371d7cc1/src/utils/api/lsk/transactions.js#L25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slaweet slaweet

Labels
type: refactoring
Projects
None yet
Milestone
Implement BTC logic, Enable Trezor T,...
Development

No branches or pull requests
1 participant
@slaweet