Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Delegate Endpoint #4631

Closed
Tracked by #4516
sridharmeganathan opened this issue Dec 4, 2022 · 0 comments · Fixed by #4681
Closed
Tracked by #4516

Adapt Delegate Endpoint #4631

sridharmeganathan opened this issue Dec 4, 2022 · 0 comments · Fixed by #4681
Assignees
@reyraa
Labels
domain: pos type: improvement
Milestone
Spike 4

Comments

@sridharmeganathan
Copy link
Contributor

sridharmeganathan commented Dec 4, 2022 •
edited by reyraa
Loading

Description

Delegate domain changed to the validator and delegates api needs to be adapted

Acceptance Criteria

  • Change useDelegates hooks to the useValidators
  • Update the HTTP & RPC endpoint
  • Update MSW mocks
  • Response has been changed please update the usage
  • Adapt unit test

Additional Information

  • HTTP GET /api/v3/pos/validators (prev: /api/v3/dpos/delegates)
  • RPC get.pos.validators (prev: get.dpos.delegates)
  • Response details
@sridharmeganathan sridharmeganathan mentioned this issue Dec 4, 2022
Closed
23 tasks
@ManuGowda ManuGowda added this to the Spike 4 milestone Dec 19, 2022
@reyraa reyraa changed the title Adopt Delegate Endpoint Adapt Delegate Endpoint Dec 20, 2022
@reyraa reyraa mentioned this issue Dec 27, 2022
Merged
@reyraa reyraa linked a pull request Dec 27, 2022 that will close this issue
Adapt Delegate Endpoint #4681
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyraa reyraa

Labels
domain: pos type: improvement
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Spike 4
Development

Successfully merging a pull request may close this issue.

Adapt Delegate Endpoint LiskHQ/lisk-desktop
3 participants
@reyraa @ManuGowda @sridharmeganathan