Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

The P2P class should not interact directly with Peer instances #1058

Closed
jondubois opened this issue Jan 30, 2019 · 1 comment
Closed

The P2P class should not interact directly with Peer instances #1058

jondubois opened this issue Jan 30, 2019 · 1 comment
Assignees
@jondubois
Labels
lisk-p2p *medium
Projects
Version 2.1.0

Comments

@jondubois
Copy link

Expected behavior

The P2P class should not interact with live Peer instances directly because we should only interact with them from a single place (which is PeerPool). The P2P class should only deal with P2PPeerInfo objects.

Actual behavior

Currently, the P2P class fetches live Peer objects from the peer pool and calls methods on them.
@jondubois jondubois self-assigned this Jan 30, 2019
@shuse2 shuse2 added this to To Do in Version 2.1.0 via automation Jan 30, 2019
@jondubois
Copy link
Author

This issue was closed by #1067

Version 2.1.0 automation moved this from To Do to Done Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jondubois jondubois

Labels
lisk-p2p *medium
Projects
No open projects
Version 2.1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jondubois @shuse2