This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Receiving blocks, transactions and signatures from v1 lisk core - Closes #1081 #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondubois
force-pushed
the
1081-inbound_issues_v1
branch
from
5639d83
to
c0e4a3c
Compare
jondubois
force-pushed
the
1081-inbound_issues_v1
branch
from
c0e4a3c
to
431ca34
Compare
shuse2
suggested changes
Feb 7, 2019
| @@ -211,7 +237,11 @@ export class Peer extends EventEmitter { | |||
| isDiscoveredPeer: true, | |||
| }; | |||
|
|
|||
| this._peerDetailedInfo = newPeerInfo; | |||
| // Some fields from the main _peerInfo cannot be overridden. | |||
| this._peerDetailedInfo = { | |||
There was a problem hiding this comment.
maybe explicitly assigning what needs to be assign is more clear what cannot be overridden?
shuse2
suggested changes
Feb 7, 2019
packages/lisk-p2p/src/peer.ts
Outdated
| if ( | ||
| packet.event === 'postBlock' || | ||
| packet.event === 'postTransactions' || | ||
| packet.event === 'postSignatures' |
There was a problem hiding this comment.
maybe below, because lint is failing here
const legacyEvents = ['postBlock', 'postTransactions', 'postSignatures'];
if (legacyEvents.includes(packet.event))
shuse2
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Inbound messages such as blocks, transactions and signatures were not received.
How did I fix it?
Added legacy event handlers to handle the three legacy cases.
How to test it?
Run node on remote testnet.
Review checklist