This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Update @liskhq/lisk-client to typescript - Closes #801 #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SargeKhan
approved these changes
Nov 13, 2018
mitsuaki-u
approved these changes
Nov 13, 2018
ishantiw
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converting lisk-client package to typescript.
In order to convert lisk-client to typescript, there was several flaws in the setup of the other project.
I have changed so that,
baseUrlfromtsconfig.json, which causes the type path reference errortypesfolder of each package to outside ofsrc.Review checklist