This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Define listeners for transaction pool related events - Closes #873 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
suggested changes
Dec 4, 2018
shuse2
suggested changes
Dec 5, 2018
added 13 commits
December 5, 2018 10:24
…n interface for lisk-transaction-pool
…optional for transaction interface for lisk-transaction-pool
SargeKhan
force-pushed
the
873-transaction_pool_events
branch
from
7c6de95
to
97a619d
Compare
added 5 commits
December 5, 2018 14:53
shuse2
reviewed
Dec 10, 2018
|
|
||
| private existsInTransactionPool(transaction: Transaction): boolean {} | ||
| public getProcessableTransactions(limit: number): ReadonlyArray<Transaction> { | ||
| return this._queues.ready.dequeueUntil( |
There was a problem hiding this comment.
Wasnt the idea to keep it in the queue until we removeConfirmedTransaction?
There was a problem hiding this comment.
This function is not just the basic implementation, I'll update this function I implement this feature.
shuse2
approved these changes
Dec 10, 2018
mitsuaki-u
reviewed
Dec 11, 2018
| verifyTransactionAgainstOtherTransactions?( | ||
| transaction: Transaction, | ||
| containsUniqueData(): boolean; | ||
| verifyTransactionAgainstOtherTransactions( |
There was a problem hiding this comment.
Leaving a comment here for future naming revision: verifyTransactionAgainstOtherTransactions -> verifyAgainstOtherTransactions
mitsuaki-u
approved these changes
Dec 11, 2018
| .map(queueName => this._queues[queueName].removeFor(condition)) | ||
| .reduce( | ||
| ( | ||
| transactionsAccumelatedFromQueues: ReadonlyArray<Transaction>, |
There was a problem hiding this comment.
transactionsAccumelatedFromQueues -> transactionsAccumulatedFromQueues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blockchain state change event listeners for the transaction pool.