This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Update required attributes - Closes #975 #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
975-update_required_attributes
branch
from
8bdd0ce
to
a174098
Compare
shuse2
changed the base branch from
base_transaction_tests
to
transaction_improvement_experiment
shuse2
force-pushed
the
975-update_required_attributes
branch
from
cdcb3de
to
5945c35
Compare
mitsuaki-u
approved these changes
Jan 10, 2019
SargeKhan
reviewed
Jan 10, 2019
shuse2
force-pushed
the
975-update_required_attributes
branch
from
5945c35
to
7b5ecf0
Compare
|
@SargeKhan Addressed |
SargeKhan
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Return type of getRequiredAttributes was not flexible enough, and we needed another function to call for filtering the entity map into usable format for each transaction.
How did I fix it?
Add EntityMap and RequiredState types and changed the input of apply, undo and verify functions.
How to test it?
npm tReview checklist