Skip to content

Commit

Permalink
🐛 Fix transaction detail page of pending transactions
Browse files Browse the repository at this point in the history
The problem was that Lisk Core API changed, 'unconfirmed' status is no
longer valid. 'ready' status is used instead.

More info:
https://lisk.io/documentation/lisk-core/api#/Node/getPooledTransactions
https://github.com/LiskHQ/lips/blob/master/proposals/lip-0006.md#queues-used-in-the-transaction-pool
  • Loading branch information
slaweet committed Aug 20, 2019
1 parent 86b9c02 commit 64dc641
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
12 changes: 1 addition & 11 deletions src/utils/api/lsk/transactions.js
Expand Up @@ -86,7 +86,7 @@ export const getSingleTransaction = ({
if (response.data.length !== 0) {
resolve(response);
} else {
apiClient.node.getTransactions('unconfirmed', { id }).then((unconfirmedRes) => {
apiClient.node.getTransactions('ready', { id }).then((unconfirmedRes) => {
if (unconfirmedRes.data.length !== 0) {
resolve(unconfirmedRes);
} else {
Expand All @@ -97,16 +97,6 @@ export const getSingleTransaction = ({
}).catch(reject);
});


export const unconfirmedTransactions = (liskAPIClient, address, limit = 20, offset = 0, sort = 'timestamp:desc') =>
liskAPIClient.node.getTransactions('unconfirmed', {
senderId: address,
limit,
offset,
sort,
});


export const create = (transaction, transactionType) => new Promise((resolve, reject) => {
try {
const tx = Lisk.transaction[transactionType](transaction);
Expand Down
10 changes: 1 addition & 9 deletions src/utils/api/lsk/transactions.test.js
Expand Up @@ -3,7 +3,6 @@ import Lisk from '@liskhq/lisk-client';
import {
send,
getTransactions,
unconfirmedTransactions,
getSingleTransaction,
create,
broadcast,
Expand Down Expand Up @@ -129,18 +128,11 @@ describe('Utils: Transactions API', () => {
it('should apiClient.node.getTransactions if empty response', async () => {
apiClient.transactions.get.mockResolvedValue({ data: [] });
const [error] = await to(getSingleTransaction({ apiClient, id }));
expect(apiClient.node.getTransactions).toHaveBeenCalledWith('unconfirmed', { id });
expect(apiClient.node.getTransactions).toHaveBeenCalledWith('ready', { id });
expect(error).toEqual(new Error(`Transaction with id "${id}" not found`));
});
});

describe('unconfirmedTransactions', () => {
it('should return a promise', () => {
const promise = unconfirmedTransactions(apiClient);
expect(typeof promise.then).toEqual('function');
});
});

describe('create', () => {
it('should create a transaction and return a promise', async () => {
const tx = {
Expand Down

0 comments on commit 64dc641

Please sign in to comment.