♻️ Move savedSettings Middleware to subscribers

src/store/index.js

@@ -6,6 +6,7 @@ import env from '../constants/env';
 import * as reducers from './reducers';
 import middleWares from './middlewares';
 import followedAccountsSubscriber from './subscribers/followedAccounts';
+import settingsSubscriber from './subscribers/settings';
 
 const App = combineReducers(reducers);
 
@@ -20,6 +21,7 @@ if (!env.test) {
 }
 
 store.subscribe(throttle(followedAccountsSubscriber.bind(null, store), 1000));
+store.subscribe(throttle(settingsSubscriber.bind(null, store), 1000));
 
 // ignore this in coverage as it is hard to test and does not run in production
 /* istanbul ignore if */

src/store/middlewares/index.js

@@ -9,7 +9,6 @@ import offlineMiddleware from './offline';
 import votingMiddleware from './voting';
 import followedAccountsMiddleware from './followedAccounts';
 import socketMiddleware from './socket';
-import savedSettingsMiddleware from './savedSettings';
 
 export default [
   thunk,
@@ -22,5 +21,4 @@ export default [
   // notificationMiddleware,
   votingMiddleware,
   followedAccountsMiddleware,
-  savedSettingsMiddleware,
 ];

src/store/subscribers/settings.js

@@ -0,0 +1,8 @@
+import { setSettingsInLocalStorage } from '../../utils/settings';
+
+const settingsSubscriber = (store) => {
+  const { settings } = store.getState();
+  setSettingsInLocalStorage(settings);
+};
+
+export default settingsSubscriber;

src/store/subscribers/settings.test.js

@@ -0,0 +1,24 @@
+import { expect } from 'chai';
+import { spy } from 'sinon';
+import settings from './settings';
+import * as settingsUtils from '../../utils/settings';
+
+describe('Subscriber: settings(state)', () => {
+  const settingsObject = {
+    currency: 'USD',
+    autoLogout: true,
+  };
+
+  it('should save accounts in localStorage', () => {
+    spy(settingsUtils, 'setSettingsInLocalStorage');
+    const state = { settings: settingsObject };
+    const store = { getState: () => state };
+
+    settings(store);
+    expect(settingsUtils.setSettingsInLocalStorage)
+      .to.have.been.calledWith(state.settings);
+
+    settingsUtils.setSettingsInLocalStorage.restore();
+  });
+});
+

src/utils/settings.js

@@ -0,0 +1,5 @@
+import localJSONStorage from './localJSONStorage';
+
+export const setSettingsInLocalStorage = settings => localJSONStorage.set('settings', settings);
+
+export const getSettingsFromLocalStorage = () => localJSONStorage.get('settings', {});

src/utils/settings.test.js

@@ -0,0 +1,48 @@
+import { expect } from 'chai';
+import { stub } from 'sinon';
+import {
+  getSettingsFromLocalStorage,
+  setSettingsInLocalStorage,
+} from './settings';
+
+describe('settings', () => {
+  const settingsObject = {
+    currency: 'USD',
+    autoLogout: true,
+  };
+
+  beforeEach(() => {
+    stub(localStorage, 'getItem');
+    stub(localStorage, 'setItem');
+  });
+
+  afterEach(() => {
+    localStorage.getItem.restore();
+    localStorage.setItem.restore();
+  });
+
+  describe('getSettingsFromLocalStorage', () => {
+    it('returns {} if if localStorage.getItem(\'settings\') returns undefined', () => {
+      expect(getSettingsFromLocalStorage()).to.deep.equal({});
+    });
+
+    it('returns {} if if localStorage.getItem(\'settings\') returns invalid JSON string', () => {
+      localStorage.getItem.returns('{]');
+      expect(getSettingsFromLocalStorage()).to.deep.equal({});
+      localStorage.getItem.returns('{}');
+      expect(getSettingsFromLocalStorage()).to.deep.equal({});
+    });
+
+    it('returns array parsed from json in localStorage.getItem(\'settings\')', () => {
+      localStorage.getItem.returns(JSON.stringify(settingsObject));
+      expect(getSettingsFromLocalStorage()).to.deep.equal(settingsObject);
+    });
+  });
+
+  describe('setSettingsInLocalStorage', () => {
+    it('sets settings in localStorage and also returns it', () => {
+      setSettingsInLocalStorage(settingsObject);
+      expect(localStorage.setItem).to.have.been.calledWith('settings', JSON.stringify(settingsObject));
+    });
+  });
+});