Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx shows duplicate after a few second in the wallet tab #1191

Closed
michieldespiegelaere opened this issue Aug 17, 2018 · 12 comments
Closed

tx shows duplicate after a few second in the wallet tab #1191

michieldespiegelaere opened this issue Aug 17, 2018 · 12 comments

Comments

@michieldespiegelaere
Copy link

Expected behaviour

Tx only showing once in the wallet while it's sending.

Actual behaviour

While the tx is sending it duplicates after a few seconds. (you can see it with the address 4560518704624832050L in the picture).

Steps to reproduce

Make a tx in lisk hub 1.1.0-rc.1.

image

@welcome
Copy link

welcome bot commented Aug 17, 2018

Thanks for opening your first issue here! Be sure to follow the issue template!

@slaweet slaweet added this to New Issues in Version 1.1.0 via automation Aug 20, 2018
@faival
Copy link
Contributor

faival commented Aug 20, 2018

Hi @michieldespiegelaere , I just reproduced steps in hub 1.1.0-rc.1 but I was unable to see the duplicate transaction effect.

Can you please perform a Ctrl + cmd + i, while on hub electron app, and provide version of hub which is displayed in the head of the document?

This way we can narrow down if there was a problem with the install of the new version.

<meta name="application-name" content="lisk-hub-1.1.0-rc.1" data-lisk-hub-version="1.1.0-rc.1">

@michieldespiegelaere
Copy link
Author

Hi @faival, I've just tried to reproduce it showed up less than friday night. I tried it to multiple addresses, with different amounts of lisk and with or without a reference.

this is what I find in the head of the document.
<meta name="application-name" content="lisk-hub-1.1.0-rc.1" data-lisk-hub-version="1.1.0-rc.1">

image

the tx with 12 lisk to 6121750279903659323L showed duplicate just before it was send.

@faival
Copy link
Contributor

faival commented Aug 20, 2018

Hi @michieldespiegelaere , it's a bit strange, the screenshot you are showing is loading a bundle with different hash than for 1.1.0-rc.1,

Hub on 1.1.0-rc.1 it's loading the following bundle hashes:

  • build/bundle.app.9caf9a3b5bd1139337e4.js
  • build/bundle.vendor.9caf9a3b5bd1139337e4.js

@michieldespiegelaere
Copy link
Author

@faival I see, could this be the problem?
my bundle hashes are

  • build/bundle.app.c202b256f52d65551ce6.js
  • build/bundle.vendor.c202b256f52d65551ce6.js

Should I retry downloading 1.1.0-rc.1 and look if my bundle hashes are different?

@faival
Copy link
Contributor

faival commented Aug 20, 2018

@michieldespiegelaere yes please, could you try installing rc.1 from scratch, and may be renaming any previous version installed?

This way we can isolate the issue to a wrong bundle hash (maybe due to the electron update process), and therefore not loading the rc.1 source code base.

@slaweet
Copy link
Contributor

slaweet commented Aug 20, 2018

@faival I think the bundle hash is just MacOS vs. Windows build difference. I'm building the entire Windows build separately from MacOs build. Somehow the hash is always different.

@michieldespiegelaere
Copy link
Author

@faival @slaweet I think that's correct about the bundle hash.

I've installed 1.1.0-rc.1 on 3 devices and they all give the same bundle hash that I posted here.

@slaweet slaweet removed this from New Issues in Version 1.1.0 Aug 22, 2018
@slaweet slaweet added this to New Issues in Version 1.2.0 via automation Aug 22, 2018
@faival
Copy link
Contributor

faival commented Aug 31, 2018

Hi, @michieldespiegelaere , I booted hub 1.1.0-rc.1 in a windows 10 with VirtualBox.

I was not able to reproduce the effect of duplicate transaction.

transaction is added as pending (with three dots)
after block updated and validated, transaction shows in the list as confirmed (not three dots and date available. )
there are no duplicated transactions.

see screenshot for version and bundle hash reference.

image

We just released 1.1.0 official release, but we couldn't generate the windows installable. Might be worth giving a try on 1.1.0 once it's available, to see if it's still reproducible.

@michieldespiegelaere
Copy link
Author

Hi @faival, it's weird but it might be just a problem on my pc. I'll give it a try for sure when it comes out!

@michieldespiegelaere
Copy link
Author

Hi @faival I've just send a tx with hub 1.1.0 and I didn't see the duplication. So we can say that this is resolved?

@slaweet
Copy link
Contributor

slaweet commented Sep 3, 2018

@michieldespiegelaere thanks for the update. I'll close the issue. We can re-open if it occurs again.

@slaweet slaweet closed this as completed Sep 3, 2018
Version 1.2.0 automation moved this from New Issues to Closed Issues Sep 3, 2018
@slaweet slaweet removed this from Closed Issues in Version 1.2.0 Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants