Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move send component steps into one folder #1419

Closed
slaweet opened this issue Nov 1, 2018 · 1 comment
Closed

Move send component steps into one folder #1419

slaweet opened this issue Nov 1, 2018 · 1 comment
Assignees
@osvaldovega
Labels
type: refactoring
Projects
Refactoring before version 1.7.0

Comments

@slaweet
Copy link
Contributor

slaweet commented Nov 1, 2018

Current behaviour

The Send components are in three folders:
https://github.com/LiskHQ/lisk-hub/tree/v1.5.0/src/components/send
https://github.com/LiskHQ/lisk-hub/tree/v1.5.0/src/components/sendWritable
https://github.com/LiskHQ/lisk-hub/tree/v1.5.0/src/components/sendReadable

Expected behaviour

All the steps are in subfolders of the send. sendWritable is renamed to form; sendReadable is renamed to confirm . Same as in https://github.com/LiskHQ/lisk-hub/tree/v1.5.0/src/components/registerDelegate/steps

/src/components/send
/src/components/send/steps/form
/src/components/send/steps/confirm
@slaweet slaweet added this to New Issues in Refactoring before version 1.7.0 via automation Nov 1, 2018
@osvaldovega osvaldovega mentioned this issue Nov 5, 2018
Merged
osvaldovega referenced this issue Nov 6, 2018
@osvaldovega
Merge pull request #1445 from LiskHQ/1419-move-send-components-steps-…
a5362d0 
…into-one-folder

Move send component steps into one folder - Closes#1419
@osvaldovega
Copy link
Contributor

Fix in PR #1445

Refactoring before version 1.7.0 automation moved this from New Issues to Closed Issues Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osvaldovega osvaldovega

Labels
type: refactoring
Projects
No open projects
Refactoring before version 1.7.0
  
Closed Issues
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slaweet @osvaldovega