Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor autosuggest lookup of placeholder method - Closes #920 #1135

Merged
merged 2 commits into from Aug 6, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Aug 3, 2018

What was the problem?

How did I fix it?

  • using a more declarative approach

How to test it?

Review checklist

@faival faival self-assigned this Aug 3, 2018
@faival faival added this to Pull Requests in Version 1.1.0 via automation Aug 3, 2018
@faival faival changed the title ♻️ refactor getValueFromCurrentIdx on autosuggest Refactor autosuggest lookup of placeholder method - Closes #920 Aug 3, 2018
Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 🥇

@faival faival merged commit 49518ae into 1.1.0 Aug 6, 2018
Version 1.1.0 automation moved this from Pull Requests to Merged Pull Requests Aug 6, 2018
@faival faival deleted the 920-refactor-autosuggest-lookup branch August 6, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.1.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

3 participants