Create general modal feedback form - closes #1166 #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faival
force-pushed
the
1166-create-general-modal-feedback-form
branch
10 times, most recently
from
53de9ea
to
87cb947
Compare
slaweet
reviewed
Aug 24, 2018
| <Button label={this.props.t('Cancel')} | ||
| onClick={() => this.props.onCancel()} | ||
| className='cancel-button' /> | ||
| <RedButton label={this.props.t('Send')} disabled={!this.state.rating} |
There was a problem hiding this comment.
I think there should be PrimaryButton to use here. RedButton was created by Mike but it doesn't have the right hover style.
faival
force-pushed
the
1166-create-general-modal-feedback-form
branch
from
2d1f923
to
a62524f
Compare
faival
force-pushed
the
1166-create-general-modal-feedback-form
branch
from
2a5af0e
to
deca8fb
Compare
|
All good, just one comment: |
|
@faival So which url parameter should i use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
#1166
How did I fix it?
How to test it?
Review checklist