Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling of network switcher on Sign In - Closes #1194 #1364

Merged
merged 2 commits into from Oct 23, 2018
Merged

Styling of network switcher on Sign In - Closes #1194 #1364

merged 2 commits into from Oct 23, 2018

Conversation

bmaggi-lisk
Copy link
Contributor

What issue have I solved?

-- #1194

How have I implemented/fixed it?

  1. Change the label font weight to --font-weight-bold

How has this been tested?

  1. Go to the login page
  2. Compare against this mock: https://user-images.githubusercontent.com/34156128/44387858-f5718d00-a526-11e8-92c6-f18ed33ef9d9.png

Review checklist

@bmaggi-lisk bmaggi-lisk self-assigned this Oct 17, 2018
@bmaggi-lisk bmaggi-lisk added this to Pull Requests in Version 1.5.0 via automation Oct 17, 2018
slaweet
slaweet suggested changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the first thing described in the issue #1194 is fixed.

The fonts of the open drop-down should be easy to fix. The close icon only if it's not too much work.

@slaweet slaweet changed the base branch from 1.5.0 to 1.6.0 October 19, 2018 14:38
@slaweet slaweet removed this from Pull Requests in Version 1.5.0 Oct 19, 2018
@slaweet slaweet added this to Pull Requests in Version 1.6.0 via automation Oct 19, 2018
@bmaggi-lisk bmaggi-lisk merged commit a98b039 into 1.6.0 Oct 23, 2018
Version 1.6.0 automation moved this from Pull Requests to Merged Pull Requests Oct 23, 2018
@bmaggi-lisk bmaggi-lisk deleted the 1194-styling-network-switcher branch October 23, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@Efefefef Efefefef Awaiting requested review from Efefefef

@hpbaxxtr hpbaxxtr Awaiting requested review from hpbaxxtr

@michaeltomasik michaeltomasik Awaiting requested review from michaeltomasik

Assignees

@bmaggi-lisk bmaggi-lisk

Labels
None yet
Projects
No open projects
Version 1.6.0
  
Merged Pull Requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmaggi-lisk @slaweet