Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and set custom node when creating new account - Closes #1326 #1396

Merged
merged 10 commits into from Nov 13, 2018

Conversation

michaeltomasik
Copy link
Contributor

@michaeltomasik michaeltomasik commented Oct 25, 2018

What issue have I solved?

-- #1326

How have I implemented/fixed it?

Implemented Validation for a custom node when clicking create new account

How has this been tested?

Try to register an account on customNode

Review checklist

@slaweet slaweet added this to Pull Requests in Version 1.6.0 via automation Oct 26, 2018
@slaweet slaweet removed this from Pull Requests in Version 1.5.0 Oct 26, 2018
@slaweet slaweet changed the base branch from 1.5.0 to 1.6.0 October 26, 2018 08:53
@michaeltomasik michaeltomasik changed the title Save custom node directly on typing - Closes #1326 Validate and set custom node when registering - Closes #1326 Nov 8, 2018
@michaeltomasik michaeltomasik changed the title Validate and set custom node when registering - Closes #1326 Validate and set custom node when creating new account - Closes #1326 Nov 8, 2018
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaeltomasik michaeltomasik merged commit 065a1b0 into 1.6.0 Nov 13, 2018
Version 1.6.0 automation moved this from Pull Requests to Merged Pull Requests Nov 13, 2018
@michaeltomasik michaeltomasik deleted the 1326-registration-custom-node-bug branch November 13, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.6.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants