Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable button and link click tracking - Closes #1453 #1628

Merged
merged 51 commits into from Jan 8, 2019

Conversation

osvaldovega
Copy link
Contributor

What issue have I solved?

-- #1453

How have I implemented/fixed it?

I function named trackEvent was created in the piwik.js file, this function is being call in every button/link function "onClick" event and what it tracks is the component name, the type button or link and the action name.

How has this been tested?

For this needs to be under the private network and run the application, after this tracking script should be enabled in the settings page, with this Matomo will start tracking the click events in the app, then once it is enable you can go to page and start navigating and doing clicks in the page and this should be track.

To confirm that is working you can logging in the Matomo admin web page and check the activity

Review checklist

Osvaldo Vega added 30 commits December 12, 2018 10:42
…s' of github.com:LiskHQ/lisk-hub into 1454-show-the-usage-tracking-switcher-in-settings-always
@osvaldovega osvaldovega added this to Open Pull Requests in Version 1.9.0 via automation Jan 4, 2019
src/components/accountInitialization/index.js Outdated Show resolved Hide resolved
src/components/registerDelegate/steps/choose/choose.js Outdated Show resolved Hide resolved
src/components/registerDelegate/steps/choose/choose.js Outdated Show resolved Hide resolved
src/components/votingListView/votingHeader.js Outdated Show resolved Hide resolved
src/components/votingListView/votingHeader.js Outdated Show resolved Hide resolved
src/components/transactions/userVotes.js Outdated Show resolved Hide resolved
src/components/transactions/accountList.js Outdated Show resolved Hide resolved
src/components/signMessage/confirmMessage.js Outdated Show resolved Hide resolved
config/setupJest.js Outdated Show resolved Hide resolved
@osvaldovega
Copy link
Contributor Author

I update all the files where the Piwik trackingEvent function is being call, in a way that be more descriptive

Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @osvaldovega

@osvaldovega osvaldovega merged commit 1d521d2 into 1.9.0 Jan 8, 2019
Version 1.9.0 automation moved this from Open Pull Requests to Merged Pull Requests Jan 8, 2019
@osvaldovega osvaldovega deleted the 1453-enable-button-and-link-click-tracking branch January 8, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.9.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants