New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable button and link click tracking - Closes #1453 #1628
Merged
osvaldovega
merged 51 commits into
1.9.0
from
1453-enable-button-and-link-click-tracking
Jan 8, 2019
Merged
Enable button and link click tracking - Closes #1453 #1628
osvaldovega
merged 51 commits into
1.9.0
from
1453-enable-button-and-link-click-tracking
Jan 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' of github.com:LiskHQ/lisk-hub into 1454-show-the-usage-tracking-switcher-in-settings-always
…tcher-in-settings-always Show the usage tracking switcher in settings always - Closes #1454
slaweet
suggested changes
Jan 4, 2019
… is called to be more descriptive
I update all the files where the Piwik trackingEvent function is being call, in a way that be more descriptive |
slaweet
suggested changes
Jan 7, 2019
slaweet
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @osvaldovega
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
-- #1453
How have I implemented/fixed it?
I function named trackEvent was created in the piwik.js file, this function is being call in every button/link function "onClick" event and what it tracks is the component name, the type button or link and the action name.
How has this been tested?
For this needs to be under the private network and run the application, after this tracking script should be enabled in the settings page, with this Matomo will start tracking the click events in the app, then once it is enable you can go to page and start navigating and doing clicks in the page and this should be track.
To confirm that is working you can logging in the Matomo admin web page and check the activity
Review checklist