Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement V2 Your Account is Created of registration - Closes #1579 #1650

Merged
merged 11 commits into from Jan 11, 2019

Conversation

massao
Copy link
Contributor

@massao massao commented Jan 10, 2019

What issue have I solved?

#1579

How have I implemented/fixed it?

Created the accountCreated component for the v2 registration process, that just shows the avatar and the address of the selected account, and a button that gets the user to the login page.

How has this been tested?

Go through the v2 registration process at /registration, this one is the last step, that shows the user the avatar and address of the account, and the user can go to the login page.
Know Issue: On this PR, there is no confirm passphrase step yet.

Review checklist

@massao massao self-assigned this Jan 10, 2019
@massao massao added this to Open Pull Requests in Version 1.9.0 via automation Jan 10, 2019
@slaweet slaweet force-pushed the 1579-registration-account-created branch from c87d7a9 to f0e2fe2 Compare January 11, 2019 12:58
@massao massao changed the base branch from 1.9.0 to development January 11, 2019 13:24
@massao massao changed the base branch from development to 1.9.0 January 11, 2019 13:24
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@massao massao merged commit ad2b6ed into 1.9.0 Jan 11, 2019
Version 1.9.0 automation moved this from Open Pull Requests to Merged Pull Requests Jan 11, 2019
@massao massao deleted the 1579-registration-account-created branch January 11, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.9.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants