Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement login with Trezor Model T - Closes #1846 #1880

Merged
merged 30 commits into from Apr 18, 2019
Merged

Implement login with Trezor Model T - Closes #1846 #1880

merged 30 commits into from Apr 18, 2019

Conversation

michaeltomasik
Copy link
Contributor

@michaeltomasik michaeltomasik commented Apr 3, 2019 •
edited

Implement login trezor model

What issue have I solved?

#1846

How have I implemented/fixed it?

  1. First, install Trezor bridge https://wallet.trezor.io/#/bridge
  2. localStorage.setItem('trezor', true) to unlock trezor login
  3. Try to log in with trezor

How has this been tested?

Review checklist

@michaeltomasik michaeltomasik self-assigned this Apr 3, 2019
osvaldovega
osvaldovega suggested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice Mike, just a few changes but are very simple.

app/src/hwManager.js Outdated Show resolved Hide resolved
app/src/hwManager.js Outdated Show resolved Hide resolved
app/src/hwManager.js Show resolved Hide resolved
app/src/trezor.js Show resolved Hide resolved
app/src/trezor.js Outdated Show resolved Hide resolved
src/components/hwWallet/trezorLoginHOC.js Outdated Show resolved Hide resolved
src/utils/api/hwWallet.js Outdated Show resolved Hide resolved
src/utils/api/hwWallet.js Outdated Show resolved Hide resolved
src/utils/api/hwWallet.js Outdated Show resolved Hide resolved
src/utils/hwWallet.js Outdated Show resolved Hide resolved
@slaweet slaweet changed the base branch from 1.15.0 to 1.16.0 April 5, 2019 14:31
osvaldovega
osvaldovega previously approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, 🏆

@slaweet slaweet changed the title Implement login trezor model - Closes #1846 Implement login trezor model T - Closes #1846 Apr 9, 2019
@slaweet slaweet changed the title Implement login trezor model T - Closes #1846 Implement login with Trezor Model T - Closes #1846 Apr 9, 2019
Efefefef
Efefefef suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@Efefefef Efefefef left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/loginV2/loginV2.js 200:9 error Method 'render' has a complexity of 11 complexity

Mike please set the pre-commit eslint check

Efefefef
Efefefef previously approved these changes Apr 15, 2019
View reviewed changes
@Efefefef Efefefef added the ready label Apr 15, 2019
@osvaldovega osvaldovega added ready and removed ready labels Apr 17, 2019
@Efefefef Efefefef removed the ready label Apr 17, 2019
@Efefefef
Copy link
Contributor

Please transfer to Pending QA after all changes are finalized

@slaweet slaweet changed the base branch from 1.16.0 to development April 18, 2019 06:30
osvaldovega
osvaldovega approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice Mike I tested and it is working

@michaeltomasik michaeltomasik merged commit b119681 into development Apr 18, 2019
@michaeltomasik michaeltomasik deleted the 1846-implement-login-trezor-model branch April 18, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osvaldovega osvaldovega osvaldovega approved these changes

@Efefefef Efefefef Efefefef left review comments

Assignees

@michaeltomasik michaeltomasik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaeltomasik @Efefefef @osvaldovega