Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement login with Trezor Model T - Closes #1846 #1880

Merged
merged 30 commits into from Apr 18, 2019

Conversation

Projects
None yet
3 participants
@michaeltomasik
Copy link
Member

commented Apr 3, 2019

Implement login trezor model

What issue have I solved?

#1846

How have I implemented/fixed it?

  1. First, install Trezor bridge https://wallet.trezor.io/#/bridge
  2. localStorage.setItem('trezor', true) to unlock trezor login
  3. Try to log in with trezor

How has this been tested?

Review checklist

michaeltomasik added some commits Mar 27, 2019

@michaeltomasik michaeltomasik self-assigned this Apr 3, 2019

@michaeltomasik michaeltomasik requested a review from osvaldovega Apr 3, 2019

@osvaldovega
Copy link
Contributor

left a comment

nice Mike, just a few changes but are very simple.

Show resolved Hide resolved app/src/hwManager.js Outdated
Show resolved Hide resolved app/src/hwManager.js Outdated
Show resolved Hide resolved app/src/hwManager.js
Show resolved Hide resolved app/src/trezor.js
Show resolved Hide resolved app/src/trezor.js Outdated
Show resolved Hide resolved src/components/hwWallet/trezorLoginHOC.js Outdated
Show resolved Hide resolved src/utils/api/hwWallet.js Outdated
Show resolved Hide resolved src/utils/api/hwWallet.js Outdated
Show resolved Hide resolved src/utils/api/hwWallet.js Outdated
Show resolved Hide resolved src/utils/hwWallet.js Outdated

@slaweet slaweet changed the base branch from 1.15.0 to 1.16.0 Apr 5, 2019

michaeltomasik added some commits Apr 7, 2019

@osvaldovega
Copy link
Contributor

left a comment

excellent, 🏆

@michaeltomasik michaeltomasik requested a review from Efefefef Apr 8, 2019

@slaweet slaweet changed the title Implement login trezor model - Closes #1846 Implement login trezor model T - Closes #1846 Apr 9, 2019

@slaweet slaweet changed the title Implement login trezor model T - Closes #1846 Implement login with Trezor Model T - Closes #1846 Apr 9, 2019

michaeltomasik added some commits Apr 9, 2019

@Efefefef
Copy link
Contributor

left a comment

src/components/loginV2/loginV2.js 200:9 error Method 'render' has a complexity of 11 complexity

Mike please set the pre-commit eslint check

osvaldovega and others added some commits Apr 11, 2019

@Efefefef Efefefef added the ready label Apr 15, 2019

osvaldovega and others added some commits Apr 17, 2019

@Efefefef Efefefef removed the ready label Apr 17, 2019

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Please transfer to Pending QA after all changes are finalized

michaeltomasik added some commits Apr 17, 2019

@slaweet slaweet changed the base branch from 1.16.0 to development Apr 18, 2019

michaeltomasik added some commits Apr 18, 2019

@osvaldovega
Copy link
Contributor

left a comment

nice Mike I tested and it is working

@osvaldovega osvaldovega added the ready label Apr 18, 2019

@michaeltomasik michaeltomasik merged commit b119681 into development Apr 18, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.441%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@michaeltomasik michaeltomasik deleted the 1846-implement-login-trezor-model branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.