Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up jest test output - Closes #1999 #2000

Merged
merged 7 commits into from May 13, 2019
Merged

Clean up jest test output - Closes #1999 #2000

merged 7 commits into from May 13, 2019

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented May 12, 2019

What issue have I solved?

#1999

How have I implemented/fixed it?

  • Fixed setup of unit tests so that there are almost no warnings

Screenshot 2019-05-10 at 14 40 32

  • The only one I couldn't find a solution for is in customRoute
  • Now it is more visible that some tests are slow and should be examined

Screenshot 2019-05-10 at 14 40 42

  • I also created a new option to run tests without generating a test coverage report for faster TDD (see README.md)

How has this been tested?

Run npm run test and see the output.

Review checklist

@slaweet slaweet requested a review from massao May 12, 2019 08:25
@slaweet slaweet self-assigned this May 12, 2019
@slaweet slaweet removed the request for review from massao May 12, 2019 18:11
massao
massao approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@massao massao requested a review from Efefefef May 13, 2019 07:11
Efefefef
Efefefef approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@Efefefef Efefefef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Efefefef Efefefef added the ready label May 13, 2019
@slaweet slaweet merged commit 23e8f49 into development May 13, 2019
@slaweet slaweet deleted the 1999-improve-jest-setup branch May 13, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massao massao massao approved these changes

@Efefefef Efefefef Efefefef approved these changes

Assignees

@slaweet slaweet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slaweet @massao @Efefefef