Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up jest test output - Closes #1999 #2000

Merged
merged 7 commits into from May 13, 2019

Conversation

Projects
None yet
3 participants
@slaweet
Copy link
Member

commented May 12, 2019

What issue have I solved?

#1999

How have I implemented/fixed it?

  • Fixed setup of unit tests so that there are almost no warnings

Screenshot 2019-05-10 at 14 40 32

  • The only one I couldn't find a solution for is in customRoute
  • Now it is more visible that some tests are slow and should be examined

Screenshot 2019-05-10 at 14 40 42

  • I also created a new option to run tests without generating a test coverage report for faster TDD (see README.md)

How has this been tested?

Run npm run test and see the output.

Review checklist

slaweet added some commits May 10, 2019

🏠 Add jest-canvas-mock
It prevents ton of this error in jest output:
 Not implemented: HTMLCanvasElement.prototype.getContext (without installing the canvas npm package)

@slaweet slaweet requested a review from massao May 12, 2019

@slaweet slaweet self-assigned this May 12, 2019

@slaweet slaweet removed the request for review from massao May 12, 2019

@massao

massao approved these changes May 13, 2019

Copy link
Contributor

left a comment

👍

@massao massao requested a review from Efefefef May 13, 2019

@Efefefef
Copy link
Contributor

left a comment

Nice

@Efefefef Efefefef added the ready label May 13, 2019

@slaweet slaweet merged commit 23e8f49 into development May 13, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.381%
Details

@slaweet slaweet deleted the 1999-improve-jest-setup branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.