Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delegates onboarding - Closes #1960 #2045

Merged
merged 20 commits into from May 23, 2019

Conversation

Projects
3 participants
@massao
Copy link
Contributor

commented May 20, 2019

What issue have I solved?

#1960

How have I implemented/fixed it?

Created onboarding component, that renders the slides based on the props, and has the navigation with animations on it, also receive the final callBack and the onClose from props.
Updated votingV2 so it renders the Onboarding if the user hadn't closed it before.

How has this been tested?

Go to /delegatesV2 and the onboarding should show up.

Review checklist

@massao massao self-assigned this May 20, 2019

massao added some commits May 21, 2019

@massao massao requested a review from osvaldovega May 22, 2019

slaweet and others added some commits May 22, 2019

@massao massao requested a review from slaweet May 23, 2019

@slaweet
Copy link
Member

left a comment

Just one detail below. Everything else looks great 👍

handleCloseOnboarding() {
localStorage.setItem('closedVotingOnboarding', true);
this.setState({ showVotingOnboarding: false });
}

This comment has been minimized.

Copy link
@slaweet

slaweet May 23, 2019

Member

handleCloseOnboarding and state.showOnboarding should IMO be inside the generic <Onboarding /> component. You just need to pass key='showVotingOnboarding' to use as the localStorage key.

@massao massao requested a review from slaweet May 23, 2019

@slaweet
Copy link
Member

left a comment

Perfect. 💯

@massao massao merged commit f2f4f57 into development May 23, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage increased (+0.02%) to 94.859%
Details

@massao massao deleted the 1960-implement-delegates-onboarding-module branch May 23, 2019

@reyraa reyraa added this to Pull Requests in Version 1.18.0 via automation May 27, 2019

@reyraa reyraa moved this from Pull Requests to Merged Pull Requests in Version 1.18.0 May 27, 2019

@reyraa reyraa added the ready label Jun 14, 2019

@reyraa reyraa added this to the Sprint 1 milestone Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.