Implement delegates onboarding - Closes #1960 #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
reviewed
May 21, 2019
slaweet
suggested changes
May 23, 2019
src/components/votingV2/votingV2.js
Outdated
| handleCloseOnboarding() { | ||
| localStorage.setItem('closedVotingOnboarding', true); | ||
| this.setState({ showVotingOnboarding: false }); | ||
| } |
There was a problem hiding this comment.
handleCloseOnboarding and state.showOnboarding should IMO be inside the generic <Onboarding /> component. You just need to pass key='showVotingOnboarding' to use as the localStorage key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
#1960
How have I implemented/fixed it?
Created onboarding component, that renders the slides based on the props, and has the navigation with animations on it, also receive the final
callBackand theonClosefrom props.Updated votingV2 so it renders the Onboarding if the user hadn't closed it before.
How has this been tested?
Go to
/delegatesV2and the onboarding should show up.Review checklist