Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase unit test coverage of reducers - Closes #456 #501

Merged
merged 12 commits into from Mar 6, 2018
Merged

Increase unit test coverage of reducers - Closes #456 #501

merged 12 commits into from Mar 6, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 2, 2018 •
edited by ginacontrino

What was the problem?

some reducers do not meet 100% coverage

How did I fix it?

increase coverage on missing cases

How to test it?

see coverage report generated

Review checklist

@faival faival requested review from reyraa and slaweet March 2, 2018 08:28
@faival faival changed the base branch from 0.2.0 to 0.3.0 March 2, 2018 11:18
@faival faival self-assigned this Mar 2, 2018
@faival faival added this to Issues in Version 0.3.0 via automation Mar 2, 2018
@faival faival added this to New Issues in Sprint Board 05-03-18 via automation Mar 2, 2018
@faival faival changed the title 496 cover savedAccounts passphrase cases Increase unit test coverage of reducers - Closes #496 Mar 2, 2018
@slaweet slaweet moved this from Issues to Pull Requests in Version 0.3.0 Mar 2, 2018
@slaweet slaweet moved this from New Issues to Pull Requests in Sprint Board 05-03-18 Mar 2, 2018
slaweet
slaweet approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Pablo

@faival faival merged commit 1ad4180 into 0.3.0 Mar 6, 2018
Version 0.3.0 automation moved this from Pull Requests to Merged Pull Requests Mar 6, 2018
Sprint Board 05-03-18 automation moved this from Pull Requests to Merged Pull Requests Mar 6, 2018
@faival faival deleted the 496-Increase-unit-test-coverage-reducers branch March 6, 2018 09:52
@faival faival changed the title Increase unit test coverage of reducers - Closes #496 Increase unit test coverage of reducers - Closes #456 Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@reyraa reyraa Awaiting requested review from reyraa

@ginacontrino ginacontrino Awaiting requested review from ginacontrino

Assignees

@faival faival

Labels
None yet
Projects
No open projects
Sprint Board 05-03-18
  
Merged Pull Requests
Version 0.3.0
  
Merged Pull Requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faival @slaweet