Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of istambul ignore - Closes #157 #546

Merged
merged 1 commit into from Mar 13, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 13, 2018

What was the problem?

Build is broken in 0.3.0 due to some missing coverage.

How did I fix it?

Add ignore istambul statement to fix build, till we cover that test

How to test it?

Jenkins build should

Review checklist

@faival faival self-assigned this Mar 13, 2018
@faival faival added this to Issues in Version 0.3.0 via automation Mar 13, 2018
@faival faival added this to New Issues in Sprint Board 12-03-18 via automation Mar 13, 2018
@faival faival changed the title Revert removal of istambul ignore Revert removal of istambul ignore - Closes #157 Mar 13, 2018
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@faival faival merged commit 3b37e81 into 0.3.0 Mar 13, 2018
Version 0.3.0 automation moved this from Issues to Merged Pull Requests Mar 13, 2018
Sprint Board 12-03-18 automation moved this from New Issues to Merged Pull Requests Mar 13, 2018
@faival faival deleted the 157-add-istambul-ignore-failing-coverage branch March 13, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint Board 12-03-18
  
Merged Pull Requests
Version 0.3.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants