Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable e2e tests - Closes #824 #861

Merged
merged 3 commits into from May 30, 2018
Merged

Fix unstable e2e tests - Closes #824 #861

merged 3 commits into from May 30, 2018

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented May 30, 2018 •
edited

What was the problem?

  • We needed to wait 15sec to ensure Tx is confirmed.
  • Because of the equal timestamps, The result of sorting of transactions isn't always the same. making the e2e tests unstable.

How did I fix it?

  • Increased the waiting time to 15sec for transaction confirmation.
  • Searched for Tx ID instead of Lisk Id and clicking the second transaction.

How to test it?

The e2e tests shouldn't fail
https://jenkins.lisk.io/job/lisk-hub/job/PR-861/

Review checklist

@reyraa reyraa self-assigned this May 30, 2018
@reyraa reyraa requested review from slaweet and faival May 30, 2018 12:44
@reyraa reyraa requested a review from ginacontrino May 30, 2018 12:44
@reyraa reyraa added this to New Issues in Sprint Board 21-05-18 via automation May 30, 2018
@reyraa reyraa added this to New Issues in Version 0.9.0 via automation May 30, 2018
@slaweet slaweet removed this from New Issues in Sprint Board 21-05-18 May 30, 2018
slaweet
slaweet approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ali

@slaweet slaweet moved this from New Issues to Pull Requests in Version 0.9.0 May 30, 2018
@reyraa reyraa merged commit f74413c into 0.9.0 May 30, 2018
Version 0.9.0 automation moved this from Pull Requests to Merged Pull Requests May 30, 2018
@reyraa reyraa deleted the 824-fix-unstable-e2e-tests branch May 30, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@faival faival Awaiting requested review from faival

@ginacontrino ginacontrino Awaiting requested review from ginacontrino

Assignees

@reyraa reyraa

Labels
None yet
Projects
No open projects
Version 0.9.0
  
Merged Pull Requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reyraa @slaweet