Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding overlay should not allow to click on UI - Closes 957 #963

Merged
merged 2 commits into from Jul 4, 2018
Merged

Onboarding overlay should not allow to click on UI - Closes 957 #963

merged 2 commits into from Jul 4, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Jun 27, 2018

What was the problem?

  • onboarding allowed to click UI elements behind the overlay background

How did I fix it?

  • a mix of changes in css, to make a layer block the pointer events
  • a flag in onboarding template to apply a z-index only when is showing

How to test it?

  • start onboarding and verify none elements can be clicked when it's open, but only the onboarding widget actions.

Review checklist

@faival faival self-assigned this Jun 27, 2018
@faival faival added this to Pull Requests in Version 0.10.0 via automation Jul 3, 2018
slaweet
slaweet approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Pablo

@slaweet slaweet merged commit 9e0e8ad into 0.10.0 Jul 4, 2018
Version 0.10.0 automation moved this from Pull Requests to Merged Pull Requests Jul 4, 2018
@slaweet slaweet deleted the 957-ui-under-onboarding-overlay-reacts-to-clicking branch July 4, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@michaeltomasik michaeltomasik Awaiting requested review from michaeltomasik

Assignees

@faival faival

Labels
None yet
Projects
No open projects
Version 0.10.0
  
Merged Pull Requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faival @slaweet