💅 Update eslint settings to match template

.eslintrc.json

@@ -1,15 +1,7 @@
 {
 	"extends": ["lisk-base"],
 	"plugins": ["mocha"],
-	"globals": {
-		"naclInstance": true
-	},
 	"rules": {
-		"arrow-parens": ["error", "as-needed"],
-		"curly": "off",
-		"indent": "off",
-		"no-confusing-arrow": "off",
-		"no-mixed-operators": "off",
 		"import/no-extraneous-dependencies": [
 			"error", {
 				"devDependencies": [
@@ -21,6 +13,9 @@
 			}
 		]
 	},
+	"globals": {
+		"naclInstance": true
+	},
 	"settings": {
 		"import/resolver": {
 			"node": {

package.json

@@ -87,9 +87,9 @@
 		"coveralls": "=3.0.0",
 		"cypress": "=2.0.2",
 		"eslint": "=4.16.0",
-		"eslint-config-airbnb-base": "=11.3.1",
-		"eslint-config-lisk-base": "=0.1.0",
-		"eslint-plugin-import": "=2.7.0",
+		"eslint-config-airbnb-base": "=12.1.0",
+		"eslint-config-lisk-base": "=1.0.0",
+		"eslint-plugin-import": "=2.8.0",
 		"eslint-plugin-mocha": "=4.11.0",
 		"http-server": "=0.10.0",
 		"husky": "=0.14.3",

src/transactions/1_registerSecondPassphrase.js

@@ -12,8 +12,8 @@
  * Removal or modification of this copyright notice is prohibited.
  *
  */
-import cryptography from 'cryptography';
 import { SIGNATURE_FEE } from 'constants';
+import cryptography from 'cryptography';
 import { wrapTransactionCreator } from './utils';
 
 const registerSecondPassphrase = ({ secondPassphrase }) => {

src/transactions/3_castVotes.js

@@ -12,8 +12,8 @@
  * Removal or modification of this copyright notice is prohibited.
  *
  */
-import cryptography from 'cryptography';
 import { VOTE_FEE } from 'constants';
+import cryptography from 'cryptography';
 import {
 	prependMinusToPublicKeys,
 	prependPlusToPublicKeys,

src/transactions/utils/validation.js

@@ -12,9 +12,9 @@
  * Removal or modification of this copyright notice is prohibited.
  *
  */
+import { MAX_ADDRESS_NUMBER } from 'constants';
 import bignum from 'browserify-bignum';
 import { hexToBuffer } from 'cryptography/convert';
-import { MAX_ADDRESS_NUMBER } from 'constants';
 
 export const validatePublicKey = publicKey => {
 	const publicKeyBuffer = hexToBuffer(publicKey);

test/.eslintrc.json

@@ -1,5 +1,4 @@
 {
-	"plugins": ["mocha"],
 	"env": {
 		"mocha": true
 	},
@@ -24,3 +23,4 @@
 		}
 	}
 }
+

test/_globalHooks.js

@@ -1,3 +1,4 @@
+/* eslint-disable mocha/no-top-level-hooks */
 afterEach(() => {
-	sandbox.restore();
+	return sandbox.restore();
 });

test/api/apiMethod.js

@@ -48,12 +48,14 @@ describe('API method module', () => {
 			handleRetry: () => {},
 		};
 		validationError = new Error('No data');
+		return Promise.resolve();
 	});
 
 	describe('#apiMethod', () => {
 		describe('when no parameters are passed', () => {
 			beforeEach(() => {
 				handler = apiMethod().bind(resource);
+				return Promise.resolve();
 			});
 
 			it('should return function', () => {
@@ -91,6 +93,7 @@ describe('API method module', () => {
 					},
 					retry: true,
 				}).bind(resource);
+				return Promise.resolve();
 			});
 
 			it('should return function', () => {
@@ -152,6 +155,7 @@ describe('API method module', () => {
 						sort: 'id',
 					},
 				}).bind(resource);
+				return Promise.resolve();
 			});
 
 			it('should return a function', () => {

test/api/apiResource.js

@@ -14,7 +14,7 @@
  */
 
 import APIResource from 'api/apiResource';
-
+// Require is used for stubbing
 const popsicle = require('popsicle');
 
 describe('API resource module', () => {
@@ -52,6 +52,7 @@ describe('API resource module', () => {
 			banActiveNodeAndSelect: sandbox.stub(),
 		};
 		resource = new APIResource(LiskAPI);
+		return Promise.resolve();
 	});
 
 	describe('#constructor', () => {
@@ -94,6 +95,7 @@ describe('API resource module', () => {
 				use: () => Promise.resolve(sendRequestResult),
 			});
 			handleRetryStub = sandbox.stub(resource, 'handleRetry');
+			return Promise.resolve();
 		});
 
 		it('should make a request to API without calling retry', () => {
@@ -130,6 +132,7 @@ describe('API resource module', () => {
 			requestStub = sandbox
 				.stub(resource, 'request')
 				.returns(Promise.resolve(sendRequestResult.body));
+			return Promise.resolve();
 		});
 
 		describe('when there is available node', () => {
@@ -138,10 +141,11 @@ describe('API resource module', () => {
 			beforeEach(() => {
 				clock = sinon.useFakeTimers();
 				LiskAPI.hasAvailableNodes = () => true;
+				return Promise.resolve();
 			});
 
 			afterEach(() => {
-				clock.restore();
+				return clock.restore();
 			});
 
 			it('should call banActiveNode when randomizeNodes is true', () => {
@@ -170,6 +174,7 @@ describe('API resource module', () => {
 		describe('when there is no available node', () => {
 			beforeEach(() => {
 				LiskAPI.hasAvailableNodes = () => false;
+				return Promise.resolve();
 			});
 
 			it('should resolve with failure response', () => {