Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

WalletConnect initialisation doesn't track error and loading state on the app #2023

Closed
Tracked by #1371
clemente-xyz opened this issue Aug 31, 2023 · 0 comments · Fixed by #2123
Closed
Tracked by #1371

WalletConnect initialisation doesn't track error and loading state on the app #2023

clemente-xyz opened this issue Aug 31, 2023 · 0 comments · Fixed by #2123

Comments

@clemente-xyz
Copy link
Contributor

clemente-xyz commented Aug 31, 2023

Description

Our WalletConnect implementation is not handling error and loading states of the library properly.

Sometimes the initialisation fails, or stills loading, and the app doesn't show the user that failure.

Also, there are some pending improvements missing to implement on the WalletConnect package that Lisk Mobile shares with Lisk Desktop.

Bellow they are listed:

  1. Include translations to plain-text content.
  2. Handle sign client initialization error (we are currently only console logging the error message).
  3. Remove await on useEffect of useSession hook.
  4. Add missing UT for hooks and utils.

See #1998 comments for more details.

@sridharmeganathan sridharmeganathan added this to the Sprint 76 milestone Nov 6, 2023
@clemente-xyz clemente-xyz changed the title WalletConnect package adaptations WalletConnect fixes Nov 9, 2023
@clemente-xyz clemente-xyz self-assigned this Nov 9, 2023
@clemente-xyz clemente-xyz changed the title WalletConnect fixes WalletConnect initialisation doesn't track error and loading state on the app Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants