Stabilize 'I should see no "{elementName}"' e2e step

LiskArchive · Aug 22, 2017 · 9b48ca9 · 9b48ca9
1 parent c650d1f
commit 9b48ca9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/features/step_definitions/generic.step.js b/features/step_definitions/generic.step.js
@@ -4,6 +4,7 @@ const chai = require('chai');
 const chaiAsPromised = require('chai-as-promised');
 const {
   waitForElemAndCheckItsText,
+  waitForElemRemoved,
   waitForElemAndClickIt,
   waitForElemAndSendKeys,
   checkAlertDialog,
@@ -77,9 +78,11 @@ defineSupportCode(({ Given, When, Then, setDefaultTimeout }) => {
   });
 
   Then('I should see no "{elementName}"', (elementName, callback) => {
-    browser.sleep(1000);
-    expect(element.all(by.css(`.${elementName.replace(/ /g, '-')}`)).count()).to.eventually.equal(0)
-      .and.notify(callback);
+    const selector = `.${elementName.replace(/ /g, '-')}`;
+    waitForElemRemoved(selector, () => {
+      expect(element.all(by.css(selector)).count()).to.eventually.equal(0)
+        .and.notify(callback);
+    });
   });
 
   Then('I should see "{text}" error message', (text, callback) => {

diff --git a/features/support/util.js b/features/support/util.js
@@ -14,6 +14,12 @@ function waitForElemAndCheckItsText(selector, text, callback) {
     .and.notify(callback || (() => {}));
 }
 
+function waitForElemRemoved(selector, callback) {
+  const elem = element(by.css(selector));
+  browser.wait(EC.not(EC.presenceOf(elem)), waitTime,
+    `waiting for element '${selector}' not present`).then(callback || (() => {}));
+}
+
 function waitForElemAndClickIt(selector, callback) {
   const elem = element(by.css(selector));
   browser.wait(EC.presenceOf(elem), waitTime, `waiting for element '${selector}'`);
@@ -39,6 +45,7 @@ function checkAlertDialog(title, text, callback) {
 
 module.exports = {
   waitForElemAndCheckItsText,
+  waitForElemRemoved,
   waitForElemAndClickIt,
   waitForElemAndSendKeys,
   checkAlertDialog,