Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix Header component #506

Closed
slaweet opened this issue Jul 21, 2017 · 1 comment · Fixed by #542 or #575
Closed

Fix Header component #506

slaweet opened this issue Jul 21, 2017 · 1 comment · Fixed by #542 or #575
Labels
bug *easy
Projects
Version 1.1.0

Comments

@slaweet
Copy link
Contributor

slaweet commented Jul 21, 2017

Expected behaviour

  • Only logo is displayed if user not logged in.
  • Logout button works.
  • Bigger margin-bottom and smaller margin-right (align open drop-down menu)
@slaweet slaweet added the bug label Jul 21, 2017
@slaweet slaweet added this to Backlog in Version 1.1.0 Jul 21, 2017
@slaweet slaweet moved this from Backlog to Ready in Version 1.1.0 Jul 25, 2017
@slaweet slaweet added the *easy label Jul 31, 2017
@alepop alepop mentioned this issue Aug 1, 2017
Merged
yasharAyari added a commit that referenced this issue Aug 1, 2017
@yasharAyari
Merge pull request #542 from alepop/506-fix-header-component
9b50d4e 
Fix header component - Closes #506
@slaweet slaweet moved this from Ready to In Progress in Version 1.1.0 Aug 1, 2017
@slaweet
Copy link
Contributor Author

slaweet commented Aug 2, 2017 •
edited

There are some more things to be fixed described as comments in #542 after it was merged. Should be fixed in another PR.

@slaweet slaweet reopened this Aug 2, 2017
@alepop alepop mentioned this issue Aug 7, 2017
Merged
slaweet added a commit that referenced this issue Aug 8, 2017
@slaweet
Merge pull request #575 from alepop/fix-header-wrapper-style
5488c87 
Fix header component style - Closes #506
@slaweet slaweet removed this from In Progress in Version 1.1.0 Aug 8, 2017
@karmacoma karmacoma added this to Closed Issues in Version 1.1.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug *easy
Projects
No open projects
Version 1.1.0
Closed Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix header component - Closes #506
Fix header component style - Closes #506
2 participants
@alepop @slaweet