Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Stabilise unit tests for generateSeed #530

Closed
slaweet opened this issue Jul 28, 2017 · 0 comments
Closed

Stabilise unit tests for generateSeed #530

slaweet opened this issue Jul 28, 2017 · 0 comments

Comments

@slaweet
Copy link
Contributor

slaweet commented Jul 28, 2017

Expected behaviour

All unit tests pass each time

Actual behaviour

Sometimes this happes

FAILED TESTS:
  Passphrase
    generateSeed
      ✖ should generate a predictable sequence of bytes for given list of randoms
        Chrome 59.0.3071 (Mac OS X 10.12.6)
      AssertionError: expected [ Array(16) ] to deeply equal undefined
          at Assertion.assertEqual (src/utils/passphrase.test.js:62131:19)
          at Assertion.ctx.(anonymous function) [as equal] (src/utils/passphrase.test.js:65569:25)
          at src/utils/passphrase.test.js:77832:48
          at Array.forEach (<anonymous>)
          at Context.<anonymous> (src/utils/passphrase.test.js:77829:15)

Steps to reproduce

Run unit tests several times

@slaweet slaweet added the test label Jul 28, 2017
@slaweet slaweet added this to Backlog in Version 1.1.0 Jul 28, 2017
@slaweet slaweet added the *easy label Jul 31, 2017
@slaweet slaweet moved this from Backlog to Ready in Version 1.1.0 Jul 31, 2017
@slaweet slaweet added the bug label Jul 31, 2017
@reyraa reyraa moved this from Ready to In Progress in Version 1.1.0 Aug 16, 2017
reyraa added a commit that referenced this issue Aug 16, 2017
@reyraa reyraa removed this from In Progress in Version 1.1.0 Aug 16, 2017
@karmacoma karmacoma added this to Closed Issues in Version 1.1.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Version 1.1.0
Closed Issues
Development

No branches or pull requests

2 participants