Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Isolate voteDialog from Voting component #723

Closed
reyraa opened this issue Sep 11, 2017 · 0 comments
Closed

Isolate voteDialog from Voting component #723

reyraa opened this issue Sep 11, 2017 · 0 comments
Assignees
@reyraa
Labels
*hard refactoring
Projects
Version 1.2.0 Sprint Board 18-09-17

Comments

@reyraa
Copy link
Contributor

reyraa commented Sep 11, 2017

Expected behaviour

As per changes in the ticket #554 , we need to be able to open every dialog individually and isolated from any related component only by means of routing. To do so, the VoteDialog should have access to the list of delegates and vote delegates though Store .

Actual behaviour

We pass the list of delegates though properties.
@reyraa reyraa self-assigned this Sep 11, 2017
@reyraa reyraa added this to Issues in Version 1.2.0 Sep 11, 2017
@reyraa reyraa added this to Issues in Sprint Board 11-09-17 Sep 11, 2017
@reyraa reyraa added *hard and removed *medium labels Sep 11, 2017
@reyraa reyraa removed this from Issues in Sprint Board 11-09-17 Sep 13, 2017
@reyraa reyraa added this to Issues in Sprint Board 18-09-17 Sep 13, 2017
@reyraa reyraa removed this from Issues in Sprint Board 18-09-17 Sep 13, 2017
@reyraa reyraa added this to Issues in Sprint Board 11-09-17 Sep 13, 2017
@reyraa reyraa mentioned this issue Sep 15, 2017
Merged
@slaweet slaweet removed this from Issues in Sprint Board 11-09-17 Sep 18, 2017
@slaweet slaweet added this to Issues in Sprint Board 18-09-17 Sep 18, 2017
reyraa added a commit that referenced this issue Sep 19, 2017
@reyraa
Merge pull request #748 from LiskHQ/723-isolate-voting-dialog
0a544a0 
Isolate voting dialog - Closes #723
@reyraa reyraa moved this from Issues to Closed Issues in Sprint Board 18-09-17 Sep 19, 2017
@reyraa reyraa moved this from Issues to Closed Issues in Version 1.2.0 Sep 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reyraa reyraa

Labels
*hard refactoring
Projects
No open projects
Sprint Board 18-09-17
Closed Issues
Version 1.2.0
Closed Issues
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reyraa