This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix account switching with custom node - Closes #995 #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
995-custom-node-account-switch
branch
from
b513ab6
to
fd86ea2
Compare
ginacontrino
approved these changes
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Account switching with custom node didn't work because the savedAccounts middleware didn't provide
addresstoactivePeerSetaction.How did I fix it?
By providing the
addresstoactivePeerSetactionHow to test it?
Follow steps in #995
Review checklist