Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix _newPeers and _triedPeers to match the LIP #3330

Closed
jondubois opened this issue Feb 21, 2019 · 1 comment
Closed

Fix _newPeers and _triedPeers to match the LIP #3330

jondubois opened this issue Feb 21, 2019 · 1 comment
Assignees

Comments

@jondubois
Copy link
Contributor

jondubois commented Feb 21, 2019

Expected behavior

Scope

The goal of this issue is to make sure that the _newPeers and _triedPeers (address book) does not grow to unlimited size. This should be done according to the LIP.

Description

This is related to https://github.com/LiskHQ/lisk-elements/issues/1072 - The _newPeers and _triedPeers maps (which store P2PDiscoveredPeerInfo) need to have a size limit to prevent DoS. The LIP has a mechanism which limits the size of the _newPeers and _triedPeers maps so it should be implemented.

Actual behavior

_newPeers and _triedPeers are not currently managed according to the LIP.

@shuse2 shuse2 transferred this issue from LiskArchive/lisk-elements Apr 15, 2019
@diego-G diego-G self-assigned this May 13, 2019
@jondubois jondubois changed the title Enforce a size limit on the _newPeers and _triedPeers lists Fix _newPeers and _triedPeers maps to match the LIP May 21, 2019
@jondubois jondubois changed the title Fix _newPeers and _triedPeers maps to match the LIP Fix _newPeers and _triedPeers to match the LIP May 21, 2019
@jondubois
Copy link
Contributor Author

jondubois commented Jun 11, 2019

This issue is there to address any remaining details which may be left over in order to fully comply with the LIP regarding the management of the the address book (_newPeers and _triedPeers).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants