Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add way to retarget specific peers on the network to account for the new LIP advertising feature #3565

Closed
jondubois opened this issue May 8, 2019 · 2 comments
Assignees

Comments

@jondubois
Copy link
Contributor

jondubois commented May 8, 2019

Expected behavior

In order to support the block/transaction advertising feature, there needs to be a mechanism for sending a request/message back to a specific peer (I.e. a peer which sent us an advertisement). This may require either adding a mechanism to bypass the default P2P routing algorithm.

Actual behavior

The core P2P API does not currently support a mechanism for sending a message to a specific peer; the routing is handled internally by the P2P library with no way to bypass the routing algorithm.

@jondubois jondubois self-assigned this May 8, 2019
@benfavre
Copy link

benfavre commented May 8, 2019

Has anyone suggested or have there been discussions about migrating to support libp2p yet ? If not, this might be the time ?

@shuse2
Copy link
Collaborator

shuse2 commented May 8, 2019

We currently have our own p2p library package called lisk-p2p, and we are trying to implement our own P2P protocol, which is described in LIP 0004.

shuse2 added a commit that referenced this issue May 28, 2019
Add way to retarget specific peers on the network to account for the new LIP advertising feature - Closes #3565
@jondubois jondubois added this to the P2P robust peer selection milestone Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants