Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Introduce specific eviction method for incoming connections #3721

Closed
diego-G opened this issue May 23, 2019 · 0 comments
Closed

Introduce specific eviction method for incoming connections #3721

diego-G opened this issue May 23, 2019 · 0 comments
Assignees
@mitsuaki-u
Labels
elements/P2P type: improvement
Milestone
Introduce robust ...

Comments

@diego-G
Copy link

diego-G commented May 23, 2019

Expected behavior

The Bitcoin eviction method was proposed in the LIP.
https://github.com/bitcoin/bitcoin/blob/17d644901bbd770578619545bbd8bc930fe6f2d9/src/net.cpp#L1000

Actual behavior

We randomly remove an ongoing incoming connection when another peer attempts to connect to us and we currently hold the maximum allowed incoming connections.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

2.0.0+
@diego-G diego-G changed the title Introduce specific eviction method to refuse incoming connections above limit Introduce specific eviction method for incoming connections May 23, 2019
@jondubois jondubois added this to the P2P robust peer selection milestone Jun 11, 2019
@jondubois jondubois mentioned this issue Jun 11, 2019
Merged
@mitsuaki-u mitsuaki-u mentioned this issue Jun 14, 2019
Merged
3 tasks
jondubois added a commit that referenced this issue Jun 26, 2019
@jondubois
Merge pull request #3824 from LiskHQ/3721_peer_eviction
f885b17 
Inbound peer eviction method - Closes #3721
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mitsuaki-u mitsuaki-u

Labels
elements/P2P type: improvement
Projects
None yet
Milestone
Introduce robust peer selection
Development

No branches or pull requests
3 participants
@jondubois @diego-G @mitsuaki-u