Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction pool doesn't respect maxTransactionsPerQueue limit #3732

Closed
4miners opened this issue May 27, 2019 · 4 comments
Closed

Transaction pool doesn't respect maxTransactionsPerQueue limit #3732

4miners opened this issue May 27, 2019 · 4 comments
Assignees

Comments

@4miners
Copy link
Contributor

4miners commented May 27, 2019

Expected behavior

It should not allow for more transactions than set in maxTransactionsPerQueue.

Actual behavior

It allows for more transactions than the configured maxTransactionsPerQueue limit.
Screen Shot 2019-05-27 at 12 46 43

Steps to reproduce

Broadcast more transactions than the default limit of 5000.

Which version(s) does this affect? (Environment, OS, etc...)

2.0.0-alpha.10

@SargeKhan
Copy link
Contributor

SargeKhan commented May 31, 2019

Transaction pool sets the limit of maximum transaction per queue only for the received queue for new transactions accepted by the node. For transactions which are moved moved to the received queue from other queues do not adhere to the maximum queue size. Which is the reason why we sometimes see transactions exceeding max transactions per queue.

@shuse2
Copy link
Member

shuse2 commented Jun 3, 2019

Closing due to expected behavior, and it is the same behavior as previous implementation

@shuse2 shuse2 closed this as completed Jun 3, 2019
@4miners
Copy link
Contributor Author

4miners commented Jun 12, 2019

Doesn't look like the limit is respected:
Screen Shot 2019-06-12 at 09 44 53

Steps to reproduce:
Run, cancel, repeat QA stress test: STRESS_COUNT=1000 npm run stress:generic

You can observe that received queue keeps growing:
Screen Shot 2019-06-12 at 09 48 06

@4miners
Copy link
Contributor Author

4miners commented Jun 17, 2019

We decided to close this issue for now.

@4miners 4miners closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants