Add P2P QA test to verify that shuffling is working as expected in outbound

[jondubois]

Expected behavior

There should be a QA test to verify that the network is not completely static and that nodes change peers from time to time. According to the LIP, for each node in the network, a random peer should be kicked out of its peer list (and disconnected) once every 5 minutes.

Actual behavior

There are no QA tests to verify shuffling. This feature did not exist prior to v2.3.

Which version(s) does this affect? (Environment, OS, etc...)

v2.3

[ishantiw]

After analyzing the logs in the alpha network, I have captured shuffling behavior which seems to remove a peer in every shuffling interval for outbound nodes. Below is some part of the logs. Since the behavior is working as expected, I will close this issue.

2019-08-16T16:03:11.925Z 'Before Shuffling'
[ '104.248.152.50',
  '178.62.188.54', // This IP is removed
  '104.248.159.16',
  '165.22.142.137',
  '68.183.201.240',
  '178.62.187.109',
  '167.71.212.116',
  '167.71.173.222',
  '167.71.43.199',
  '68.183.201.186' ]
2019-08-16T16:03:11.926Z 'After Shuffling'
[ '104.248.152.50',
  '104.248.159.16',
  '165.22.142.137',
  '68.183.201.240',
  '178.62.187.109',
  '167.71.212.116',
  '167.71.173.222',
  '167.71.43.199',
  '68.183.201.186' ]

2019-08-16T16:03:05.924Z 'Before Shuffling'
[ '104.248.146.160',
  '104.248.152.50',
  '178.62.188.54',
  '104.248.159.16',
  '165.22.77.144',
  '167.71.227.238',
  '167.71.217.197',
  '165.22.39.0',
  '165.22.198.30',
  '165.22.142.137',
  '68.183.201.240',
  '104.248.193.141',
  '134.209.98.141',
  '178.62.187.109',
  '167.71.212.116',
  '167.71.173.222',
  '167.71.227.31',
  '167.71.43.199',
  '68.183.201.183', // This IP is removed
  '68.183.201.186' ]
2019-08-16T16:03:05.925Z 'After Shuffling'
[ '104.248.146.160',
  '104.248.152.50',
  '178.62.188.54',
  '104.248.159.16',
  '165.22.77.144',
  '167.71.227.238',
  '167.71.217.197',
  '165.22.39.0',
  '165.22.198.30',
  '165.22.142.137',
  '68.183.201.240',
  '104.248.193.141',
  '134.209.98.141',
  '178.62.187.109',
  '167.71.212.116',
  '167.71.173.222',
  '167.71.227.31',
  '167.71.43.199',
  '68.183.201.186' ]