Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add check for non-existent actions and add tests to cover #4081

Closed
michielmulders opened this issue Aug 14, 2019 · 0 comments
Closed

Add check for non-existent actions and add tests to cover #4081

michielmulders opened this issue Aug 14, 2019 · 0 comments

Comments

@michielmulders
Copy link
Contributor

Expected behavior

It should not be possible to call any action on a module, even non-existent actions which can cause side effects. The module should return a proper error message when the action does not exist.

--> Referring to discussion leading up to this issue.

Tests needed for:

  • channel.invoke('chain:mycustomactionwhichdoesnotexist', ...)
  • channel.invoke('mycustomactionwhichdoesnotexist', ...) -> should be ok as default is chain but not for other domains
  • channel.invoke('notchain:mycustomactionwhichdoesnotexist', ...)

Steps to reproduce

See the above test cases.

Which version(s) does this affect? (Environment, OS, etc...)

2.*

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants