Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Syncing should revert a block when loading from network failed #4103

Closed
shuse2 opened this issue Aug 16, 2019 · 0 comments
Closed

Syncing should revert a block when loading from network failed #4103

shuse2 opened this issue Aug 16, 2019 · 0 comments
Assignees

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Aug 16, 2019

Expected behavior

Syncing should revert the block when it fails to load blocks from the network, but not when it fails to process.

https://github.com/LiskHQ/lisk-sdk/blob/v1.6.0/framework/src/modules/chain/submodules/blocks/process.js#L254-L343

Actual behavior

Behavior is opposite. It reverts a block when it fails to process, but it does not revert on the network load fails.

Steps to reproduce

Build a blockchain in a network, and connect to another network with the same dataset.

Which version(s) does this affect? (Environment, OS, etc...)

2.2-

@shuse2 shuse2 self-assigned this Aug 16, 2019
shuse2 added a commit that referenced this issue Aug 16, 2019
Fix syncing logic for reverting - Closes #4103
@shuse2 shuse2 closed this as completed Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant