Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add unit test coverage for P2P peer directory folder #4227

Closed
diego-G opened this issue Sep 9, 2019 · 0 comments · Fixed by #4377
Closed

Add unit test coverage for P2P peer directory folder #4227

diego-G opened this issue Sep 9, 2019 · 0 comments · Fixed by #4377
Assignees
@diego-G
Labels
elements/P2P type: test
Milestone
Sprint 7

Comments

@diego-G
Copy link

diego-G commented Sep 9, 2019 •
edited
Loading

Expected behavior

Every file from lisk-p2p library is well covered with unit test. The minimum must be 80% at least to achieve green reports.

Actual behavior

peer_directory/ counts with only 75% coverage.

Steps to reproduce

npm t

Which version(s) does this affect? (Environment, OS, etc...)

+2.3
@diego-G diego-G added this to the Sprint 6 - P2P milestone Sep 9, 2019
@ishantiw ishantiw mentioned this issue Sep 9, 2019
Closed
11 tasks
@diego-G diego-G changed the title Add unit test coverage for P2P tried_list file Add unit test coverage for P2P peer directory folder Sep 27, 2019
@diego-G diego-G assigned diego-G and ishantiw and unassigned diego-G Sep 27, 2019
@diego-G diego-G mentioned this issue Sep 27, 2019
Closed
@diego-G diego-G mentioned this issue Oct 8, 2019
Merged
5 tasks
shuse2 added a commit that referenced this issue Oct 14, 2019
@shuse2
Merge pull request #4377 from LiskHQ/4227-add_unit_test_to_P2P_peer_d…
a32eb03 
…irectory

Increase unit test coverage across P2P peer book - Closes #4227
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diego-G diego-G

Labels
elements/P2P type: test
Projects
None yet
Milestone
Sprint 7
Development

Successfully merging a pull request may close this issue.

Increase unit test coverage across P2P peer book - Closes #4227 LiskArchive/lisk-sdk
3 participants
@diego-G @ishantiw @sridharmeganathan