Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getBasicBytes and getAssetBytes in transaction library #4334

Closed
shuse2 opened this issue Sep 27, 2019 · 0 comments
Closed

Update getBasicBytes and getAssetBytes in transaction library #4334

shuse2 opened this issue Sep 27, 2019 · 0 comments
Assignees
@mitsuaki-u
Labels
elements/transactions
Milestone
Sprint 9

Comments

@shuse2
Copy link
Member

shuse2 commented Sep 27, 2019 •
edited

Description

Related to LIP-0009 and LIP-0012

getBasicBytes and getAssetBytes needs to be updated.

  • it should update the order and endianness of bytes described in LIP-0012 (Checked with research and we can normalise the endianness for all fields)

Motivation

Motivation is described in

Acceptance Criteria

  • It generates network identifier
  • All the test needs to be updated
  • Require review from research team

Additional Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitsuaki-u mitsuaki-u

Labels
elements/transactions
Projects
None yet
Milestone
Sprint 9
Development

No branches or pull requests
3 participants
@shuse2 @mitsuaki-u @sridharmeganathan