Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unused code and integration tests #5614

Closed
shuse2 opened this issue Aug 4, 2020 · 0 comments · Fixed by #5662
Closed

Cleanup unused code and integration tests #5614

shuse2 opened this issue Aug 4, 2020 · 0 comments · Fixed by #5662
Assignees
@shuse2
Labels
sdk type: refactoring type: test
Milestone
Sprint 26

Comments

@shuse2
Copy link
Member

shuse2 commented Aug 4, 2020 •
edited by karmacoma

Description

  • Remove lisk-dpos package
  • Remove CustomTransaction in lisk-transactions and unused utility logics
  • Fix all broken integration tests

Motivation

All non-used code should be removed.

Acceptance criteria

  • DPoS dependency does not exist
  • Update all unit tests and integration tests
  • All tests are green without skip

Related Issues

#5603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuse2 shuse2

Labels
sdk type: refactoring type: test
Projects
None yet
Milestone
Sprint 26
Development

Successfully merging a pull request may close this issue.

Cleanup on chain architecture - Closes #5614 LiskHQ/lisk-sdk
3 participants
@shuse2 @ManuGowda @sridharmeganathan