You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
lisk-client library should be allowed to use both node and browser version. e.g import * as liskClient from 'lisk-client/node,import * as liskClient from 'lisk-client/browser. and the default behaviour can be supported for browser import * as liskClient from 'lisk-client.
Motivation
Lisk Desktop and Lisk Mobile testing environment requires the both browser buffer (due to lisk-client) and nodejs buffer (due to btc libraries). Supporting both the buffer instances is a challenge, if we an ability to import lisk-client as nodejs, then both will be supported
shuse2
changed the title
Export browser and nodejs buffer compatible lisk-client
Export browser and nodejs compatible buffer from lisk-client
Oct 13, 2021
Reopening this issue because with @chainsafe/blst library included in the lisk-cryptography library, the faucet ui build will fail with below if we use node version of lisk-client library.
❯ CI=true yarn build:web
yarn run v1.22.10
$ node scripts/build.js --jsx react
Creating an optimized production build...
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.
Failed to compile.
/lisk-sdk/node_modules/@chainsafe/blst/dist/bindings.js
Critical dependency: the request of a dependency is an expression
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
With Typescript, it is not possible to use exports feature on package.json yet, but it will be available in next 4.5. microsoft/TypeScript#33079.
Most likely, even if the exports will be supported, webpack build will fail with the above error. Therefore, browser version to be the default seems to make more sense for lisk-client package.
Temporally reverting the change to default to browser version of the build with 34849e0 in #6869.
When fixing this again, lisk-desktop/lisk-mobile developers must be consulted.
Description
lisk-client
library should be allowed to use both node and browser version. e.gimport * as liskClient from 'lisk-client/node
,import * as liskClient from 'lisk-client/browser
. and the default behaviour can be supported for browserimport * as liskClient from 'lisk-client
.Motivation
Lisk Desktop and Lisk Mobile testing environment requires the both browser buffer (due to lisk-client) and nodejs buffer (due to btc libraries). Supporting both the buffer instances is a challenge, if we an ability to import lisk-client as nodejs, then both will be supported
Additional Information
LiskHQ/lisk-desktop#3804
LiskArchive/lisk-mobile#1102
The text was updated successfully, but these errors were encountered: