Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow same commission in the change commission #8224

Closed
Tracked by #7210
shuse2 opened this issue Mar 3, 2023 · 0 comments · Fixed by #8248
Closed
Tracked by #7210

Allow same commission in the change commission #8224

shuse2 opened this issue Mar 3, 2023 · 0 comments · Fixed by #8248
Assignees
Milestone

Comments

@shuse2
Copy link
Member

shuse2 commented Mar 3, 2023

Description

In the changeCommission command execution, lastCommission increased height should be increased when value are the same as in below

if trsParams.newCommission >= oldCommission:
        b = block including trs
        validatorStore(senderAddress).lastCommissionIncreaseHeight = b.header.height

Acceptance Criteria

  • It should test the case where trsParams.newCommission == oldCommission:

Additional Information

Related LIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants