Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to Accounts entity to allow searching in account.asset field - Closes #3990 #4078

Merged
merged 10 commits into from Aug 14, 2019

Conversation

@pablitovicente
Copy link
Contributor

pablitovicente commented Aug 14, 2019

What was the problem?

It was not possible to search in the account's asset field

How did I solve it?

By adding new filters asset_contains and asset_exists to the accounts entity

How to manually test it?

run npm run mocha:unit test/mocha/unit/components/storage/entities/account.js and check tests added to this PR

Review checklist

  • The PR resolves #3990
  • All new code is covered with unit tests
  • Relevant integration / functional tests are added
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated
lsilvs and others added 2 commits Aug 9, 2019
wip
@pablitovicente pablitovicente requested review from lsilvs and michielmulders Aug 14, 2019
@pablitovicente pablitovicente self-assigned this Aug 14, 2019
@pablitovicente pablitovicente force-pushed the 3990-add-account-asset-filters-rebased branch from 7a6bf9f to 57d6f81 Aug 14, 2019
lsilvs and others added 3 commits Aug 9, 2019
@lsilvs lsilvs force-pushed the 3990-add-account-asset-filters-rebased branch from 57d6f81 to 8f42e21 Aug 14, 2019
@lsilvs
lsilvs approved these changes Aug 14, 2019
Copy link
Member

lsilvs left a comment

lgtm

@pablitovicente pablitovicente requested a review from michielmulders Aug 14, 2019
…iskHQ/lisk-sdk into 3990-add-account-asset-filters-rebased
@pablitovicente pablitovicente requested a review from michielmulders Aug 14, 2019
Copy link
Contributor

michielmulders left a comment

You are now a testing warrior! 🚶

@shuse2
shuse2 approved these changes Aug 14, 2019
@shuse2 shuse2 added this to Open PRs in Version 3.0.0 via automation Aug 14, 2019
@shuse2 shuse2 merged commit 83694a1 into development Aug 14, 2019
2 checks passed
2 checks passed
jenkins-ci/sdk This commit looks good
Details
test-coverage-plugin Coverage 76% changed +0.79% vs master 75%
Details
Version 3.0.0 automation moved this from Open PRs to Closed PRs Aug 14, 2019
@shuse2 shuse2 deleted the 3990-add-account-asset-filters-rebased branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 3.0.0
  
Merged PRs
4 participants
You can’t perform that action at this time.