This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add filter to Accounts entity to allow searching in account.asset field - Closes #3990 #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablitovicente
force-pushed
the
3990-add-account-asset-filters-rebased
branch
from
7a6bf9f
to
57d6f81
Compare
lsilvs
force-pushed
the
3990-add-account-asset-filters-rebased
branch
from
57d6f81
to
8f42e21
Compare
michielmulders
suggested changes
Aug 14, 2019
…iskHQ/lisk-sdk into 3990-add-account-asset-filters-rebased
michielmulders
approved these changes
Aug 14, 2019
shuse2
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
It was not possible to search in the account's asset field
How did I solve it?
By adding new filters
asset_containsandasset_existsto the accounts entityHow to manually test it?
run
npm run mocha:unit test/mocha/unit/components/storage/entities/account.jsand check tests added to this PRReview checklist