This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add network ready event - Closes #4090 #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
force-pushed
the
4090_network_ready
branch
from
0104c9f
to
12f2cf0
Compare
ManuGowda
reviewed
Aug 16, 2019
ishantiw
previously requested changes
Aug 16, 2019
shuse2
approved these changes
Aug 16, 2019
ishantiw
approved these changes
Aug 16, 2019
jondubois
suggested changes
Aug 16, 2019
jondubois
approved these changes
Aug 16, 2019
jondubois
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Node was attempting to load transactions and signatures before it was connected to any peers on p2p network. This caused an error message:
RequestFailError: Request failed due to no peers found in peer selection.How did I solve it?
Created
EVENT_NETWORK_READYwhich the network module listens for before publishingnetwork:bootstrapand callingloader.loadTransactionsAndSignatures.peerSelectForRequestnow simply shuffles peerList and selects one, instead of using height histogram.How to manually test it?
Start 2.3.0 node and connect to testnet. Observe that there is no
RequestFailError.Review checklist