Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Trying to upgrade non-existing instance does not return non-zero exit code - Closes #3928 #4102

Merged
merged 4 commits into from
Aug 16, 2019

Conversation

ManuGowda
Copy link
Contributor

What was the problem?

Trying to upgrade non-existing instance does not return non-zero exit code

How did I solve it?

Returning non-zero code for non-existing instance

How to manually test it?

lisk core:status idontexist
lisk core:upgrade meneither

Review checklist

Copy link
Contributor

@fchavant fchavant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lisk core:upgrade instance_that_does_not_exist nows exits with code 2

@shuse2 shuse2 merged commit 401547b into release/2.3.0 Aug 16, 2019
@shuse2 shuse2 deleted the 3928-core-command-handle-command-exit branch August 16, 2019 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants